test: adapt Mistral to OpenAI refactoring #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
commented
Jan 2, 2025
Comment on lines
+98
to
+99
| for key, value in expected_params.items(): | ||
| assert data["init_parameters"][key] == value |
There was a problem hiding this comment.
This avoids the test failure if there are other params in addition to those expected
Comment on lines
+201
to
+206
| try: | ||
| # Haystack >= 2.9.0 | ||
| component._check_finish_reason(m.meta) | ||
| except AttributeError: | ||
| # Haystack < 2.9.0 | ||
| component._check_finish_reason(m) |
There was a problem hiding this comment.
this is ugly, but we can get rid of it after releasing Haystack 2.9.0
(I'll create an issue to track that)
anakin87
changed the title
mpangrazzi
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
OpenAIChatGeneratorwas refactored in feat: support for tools inOpenAIChatGeneratorhaystack#8666 and Mistral inherits from itProposed Changes:
Fix tests
How did you test it?
CI; local tests with Haystack main.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.