refactor!: AmazonBedrockGenerator - remove truncation #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:amazon-bedrock
type:documentation
vblagoje
requested review from
mpangrazzi and
anakin87
and removed request for
a team and
mpangrazzi
|
@mpangrazzi not to distract you with something that @anakin87 is already familiar with and has complete context. @anakin87 I know we are not following deprecation policy here but with generators being slowly removed anyways I thought it would be an overkill to follow the policy here - so I just eviscerated the truncation support altogether. And we have internal support to remove it right away 👍 |
anakin87
requested changes
Jan 22, 2025
...s/amazon_bedrock/src/haystack_integrations/components/generators/amazon_bedrock/generator.py
Outdated
Show resolved
Hide resolved
…ts/generators/amazon_bedrock/generator.py Co-authored-by: Stefano Fiorucci <[email protected]>
vblagoje
changed the title
anakin87
approved these changes
Jan 22, 2025
Amnah199
pushed a commit
that referenced
this pull request
Jan 28, 2025
* AmazonBedrockGenerator - remove truncation * Update tests * Linting * Remove deprecation test * Update docs config * Update integrations/amazon_bedrock/src/haystack_integrations/components/generators/amazon_bedrock/generator.py Co-authored-by: Stefano Fiorucci <[email protected]> * Lint --------- Co-authored-by: Stefano Fiorucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Remove truncation in AmazonBedrockGenerator.
What:
transformersdependency from thepyproject.toml.max_lengthandtruncateparameters and associated warning logic from the generator.DefaultPromptHandlerclass along with associated prompt truncation logic.How can it be used:
See above
How did you test it:
Notes for the reviewer:
Please focus on the removal of the prompt handler logic and verify that all necessary tests continue to pass. Special attention may be needed to confirm that
max_lengthandtruncateparameters' deprecation does not affect downstream functionality or produce any warnings at runtime.