-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ollama Integration #132
Ollama Integration #132
Conversation
…airLR112/haystack-core-integrations into feature/ollama_integration main branch ahead of this local feature branch
Hello, @AlistairLR112 and @sachinsachdeva... I also created an issue in this repo (#146) that reminds us what we should do to declare the integration done.
|
Hey @anakin87 ,
|
Thanks @sachinsachdeva! I agree with you about adding streaming later! |
…airLR112/haystack-core-integrations into feature/ollama_integration Integrate upstream changes into local
@AlistairLR112 I finally managed to run Ollama for tests, taking a cue from your suggestion! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlistairLR112 I left some comments about aspects that can be improved.
Please let me know if you can address them...
I will also push some minor changes to this PR
- testing workflow: I will probably change something on how we spin up the Ollama service and then update the README accordingly
- add this integration to the inventory in the general README of core integrations
Co-authored-by: Stefano Fiorucci <[email protected]>
…airLR112/haystack-core-integrations into feature/ollama_integration add remote github actions changes
Apologies, forgot to modify a test there.. |
@AlistairLR112 I intend to make some final refinements to docstring and other small things, |
I suspect some of the changes will be getting rid of my silly test cases! Do let me know when it's all done, would like to make a post about it on linkedin if you are okay with that! |
I will try to merge this PR today... Of course, the contribution is yours, so you can also announce it in advance if you prefer. |
Hey @anakin87, I will wait until everything is done, let me know where I can help. Has been fantastic to collab with you too! Happy to add more integrations :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This first implementation is good to go!
Merging...
My incomplete attempt at the Ollama Integration to complement @sachinsachdeva
#126
Referring to this:
#146