Pinecone - filters #133
Merged
Pinecone - filters #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
requested review from
ZanSara
and removed request for
a team and
ZanSara
anakin87
force-pushed
the
pinecone-filters
branch
from
b69f747 to
435da6a
Compare
masci
suggested changes
Dec 22, 2023
| "not in": _not_in, | ||
| } | ||
|
|
||
| LOGICAL_OPERATORS = {"AND": "$and", "OR": "$or"} |
There was a problem hiding this comment.
I would put module constants at the top
There was a problem hiding this comment.
The fact is that COMPARISON_OPERATORS depends on some functions, so they should live after the function definitions.
And I would prefer LOGICAL_OPERATORS to be close.
Co-authored-by: Massimiliano Pippi <[email protected]>
…tack-core-integrations into pinecone-filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.