Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Azure AI Search - improvements to the test suite #1425

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Feb 21, 2025

Related Issues

While running unit tests locally with hatch run test -m "not integration",
I encountered several errors due to the fact that the test suite tries to clean up Azure indexes at the end of session, even if I only run local unit tests.

I should be able to locally run the unit tests without worrying about API keys or encountering errors.

Proposed Changes:

  • refactor the cleanup_indexes fixture to only clean up indexes when we execute integration tests
  • add some missing integration markers

How did you test it?

Local runs; CI

Checklist

@github-actions github-actions bot added integration:azure-ai-search type:documentation Improvements or additions to documentation labels Feb 21, 2025
@anakin87 anakin87 marked this pull request as ready for review February 21, 2025 14:15
@anakin87 anakin87 requested a review from a team as a code owner February 21, 2025 14:15
@anakin87 anakin87 requested review from mpangrazzi and removed request for a team February 21, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:azure-ai-search type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant