Adding AstraDB as a DocumentStore #144
Conversation
|
|
There was a problem hiding this comment.
Hello @hc33brackles Thank you for opening this PR. It looks quite good already! 👍 I left some comments after reviewing the code. However, I didn't have the time to run the examples yet. Please let me know if you have any questions regarding the review. 🙂
|
@hc33brackles By the way, in order to run the other CI steps, the Contributor License Agreement needs to be signed by all contributors. You can find the check above: #144 (comment) |
|
@julian-risch - we are still responding to some comments but all contributors have signed! |
|
@julian-risch We just pushed all the needed fixes and added our CI work as well. |
|
Mouna is working on the linting issues, but there might be something more underlying with the way we changed the astra secrets to be handled is causing some of the errors in the python components. @julian-risch - I think if you input the ASTRA_DB_APPLICATION_TOKEN and ASTRA_DB_ID to the test repo as repo secrets these tests will pass. |
mounaTay
force-pushed
the
main
branch
8 times, most recently
from
099a730 to
3cb6d0d
Compare
There was a problem hiding this comment.
Looks all very good to me! 👍 We just need to skip the tests when the API secret tokens are not available. I suggested the required changes so that you can commit them directly from the UI. I couldn't commit to your branch directly.
Thank you @mounaTay for your help running the tests locally and confirming the availability of the keys was an issue.
Once the changes I suggested with this review are committed the CI should pass and I will approve and merge the PR.
…ore.py imports and tests for haysyack 2.0, remove readme, license, and pyproject.toml from tests dir
Co-authored-by: Julian Risch <[email protected]>
This is the PR discussed with Masci and Tuana which adds Astra using the JSON API as a DocumentStore for Haystack built for Haystack 2.0.
All unit tests passing.
Working examples.
Looking forward to feedback. :-) --Nick