Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VertexAI prefix to GeminiGenerator and GeminiChatGenerator components #166

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Add VertexAI prefix to GeminiGenerator and GeminiChatGenerator components #166

merged 1 commit into from
Jan 3, 2024

Conversation

silvanocerza
Copy link
Contributor

To differentiate generators using Gemini we add this VertexAI prefix as we'd done with the google-ai-haystack integration that has the GoogleAI prefix for the Gemini generators.

@silvanocerza silvanocerza self-assigned this Jan 3, 2024
@silvanocerza silvanocerza requested a review from a team as a code owner January 3, 2024 11:33
@silvanocerza silvanocerza requested review from anakin87 and removed request for a team January 3, 2024 11:33
anakin87
anakin87 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@silvanocerza silvanocerza merged commit b252d72 into main Jan 3, 2024
9 checks passed
@silvanocerza silvanocerza deleted the prefix-vertex-ai-components branch January 3, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

Assignees

@silvanocerza silvanocerza

Labels
integration:google-vertex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvanocerza @anakin87