-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pgvector datastore #172
Add pgvector datastore #172
Conversation
Hey @anakin87, I'm diving into implementing vector data store for the first time, and I have made some progress. However, there are a few areas where I could use your expertise: Configuration File (.toml):I've made some headway on the feature, but I'm stuck on finalizing the .toml file. I couldn't fully grasp what was happening there. Any guidance you can provide would be immensely helpful. Test Case Implementation:I haven't had much experience writing test cases before, and I want to ensure robust testing for this feature. Your assistance in creating effective test cases would be invaluable to ensure the reliability of the codebase. Retriever Module (retriever.py):In the I appreciate your support. |
Hello, @sahusiddharth. I took the time to get a first look... Client
Other suggestions
What I will do
Feel free to ask specific questions/doubts... |
This is the most basic requirement for the child class: provide | ||
an instance of this document store so the base class can use it. | ||
""" | ||
return PGvectorDocumentStore() # FIXME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sahusiddharth here you should put a valid instance of your Document Store to run tests...
Currently, it is only a placeholder.
I added the GitHub workflow that runs tests. Now they are running. See also #172 (comment) |
Thank you @anakin87 |
Hey, @sahusiddharth... |
Thanks for checking on me. |
No rush! If you need any help or clarification, please ask... |
Since there was no progress on this PR for a while, we decided to implement the @sahusiddharth thank you for your efforts. |
fixes: #142