Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pgvector datastore #172

Closed

Conversation

sahusiddharth
Copy link
Contributor

fixes: #142

@sahusiddharth sahusiddharth requested a review from a team as a code owner January 4, 2024 14:48
@sahusiddharth sahusiddharth requested review from anakin87 and removed request for a team January 4, 2024 14:48
@sahusiddharth
Copy link
Contributor Author

Hey @anakin87,

I'm diving into implementing vector data store for the first time, and I have made some progress. However, there are a few areas where I could use your expertise:

Configuration File (.toml):

I've made some headway on the feature, but I'm stuck on finalizing the .toml file. I couldn't fully grasp what was happening there. Any guidance you can provide would be immensely helpful.

Test Case Implementation:

I haven't had much experience writing test cases before, and I want to ensure robust testing for this feature. Your assistance in creating effective test cases would be invaluable to ensure the reliability of the codebase.

Retriever Module (retriever.py):

In the run function of the retriever.py module, there are some aspects I'm unsure about, and I have a few questions. I believe your insights could help me iron out the details.

I appreciate your support.

@anakin87 anakin87 self-assigned this Jan 5, 2024
@anakin87
Copy link
Member

anakin87 commented Jan 5, 2024

Hello, @sahusiddharth.

I took the time to get a first look...
This integration won't be trivial but can be a good experience.

Client

Other suggestions

What I will do

  • I will setup for you the GitHub testing workflow, so for each commit, the CI will run tests that you can use to drive your development process (of course, you can still run them locally)

Feel free to ask specific questions/doubts...

This is the most basic requirement for the child class: provide
an instance of this document store so the base class can use it.
"""
return PGvectorDocumentStore() # FIXME
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sahusiddharth here you should put a valid instance of your Document Store to run tests...
Currently, it is only a placeholder.

@anakin87
Copy link
Member

anakin87 commented Jan 5, 2024

I added the GitHub workflow that runs tests. Now they are running. See also #172 (comment)

@sahusiddharth
Copy link
Contributor Author

Thank you @anakin87

@anakin87
Copy link
Member

Hey, @sahusiddharth...
If you need help, feel free to let me know!

@sahusiddharth
Copy link
Contributor Author

@anakin87

Thanks for checking on me.
Was out of station, didn't get a change to resume working on it, I'll start today

@anakin87
Copy link
Member

No rush! If you need any help or clarification, please ask...

@anakin87
Copy link
Member

Since there was no progress on this PR for a while, we decided to implement the PgvectorDocumentStore in another PR (#239).

@sahusiddharth thank you for your efforts.
I see that you have already found other opportunities to contribute to Haystack. Thank you again!

@anakin87 anakin87 closed this Jan 19, 2024
@sahusiddharth sahusiddharth deleted the add-pgvector-datastore branch January 19, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PGVector DocumentStore
2 participants