Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Rename model_path to model in the Llama.cpp integration #243

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Jan 18, 2024

Related Issues:

Proposed Changes:

  • Rename model_path to model in the embedders of the Llama.cpp integration

How did you test it?

Local tests run, CI

Note for the reviewer

This integration is a bit different from the others because it only expects a model path, so the name might be justified. However, for consistency I preferred to standardize this one as well. Feel free to object this change if we prefer to leave the parameter's name unchanged instead.

@ZanSara ZanSara changed the title chore!: Rename model_name to model in the Llama.cpp integration chore!: Rename model_path to model in the Llama.cpp integration Jan 18, 2024
@ZanSara ZanSara marked this pull request as ready for review January 18, 2024 13:56
@ZanSara ZanSara requested a review from a team as a code owner January 18, 2024 13:56
@ZanSara ZanSara requested review from silvanocerza and removed request for a team January 18, 2024 13:56
@ZanSara ZanSara merged commit ed92810 into main Jan 22, 2024
9 checks passed
@ZanSara ZanSara deleted the apply-6534-to-llamacpp branch January 22, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants