Ollama Text Embedder with new format #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlistairLR112
requested review from
julian-risch
and removed request for
a team
julian-risch
previously requested changes
Jan 25, 2024
There was a problem hiding this comment.
@AlistairLR112 Thank you for opening this pull request. It looks very good to me already! I just have a question about the generation_kwargs. What options are supported here? From the user perspective it looks the same options as for the generators but I doubt that. Can you explain the options?
integrations/ollama/src/haystack_integrations/components/embedders/ollama/text_embedder.py
Show resolved
Hide resolved
integrations/ollama/src/haystack_integrations/components/embedders/ollama/text_embedder.py
Outdated
Show resolved
Hide resolved
anakin87
dismissed
julian-risch’s stale review
feedback was addressed correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrating Embeddings generated from Ollama into Haystack