Support more collection settings when creating a new WeaviateDocumentStore
#260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
reviewed
Jan 24, 2024
integrations/weaviate/src/haystack_integrations/document_stores/weaviate/document_store.py
Show resolved
Hide resolved
| - blob_data: blob | ||
| - blob_mime_type: text | ||
| - score: number | ||
| See the official `Weaviate documentation<https://weaviate.io/developers/weaviate/manage-data/collections>`_ |
There was a problem hiding this comment.
I'm just curious about this format for links...
Is it Sphinx? Is it supported in ReadMe?
Should it be Link text <link URL>?
There was a problem hiding this comment.
This should be handle by pydoc when converting the docstrings to Markdown.
In any case we need to standardise the docstrings sooner than later.
integrations/weaviate/src/haystack_integrations/document_stores/weaviate/document_store.py
Show resolved
Hide resolved
anakin87
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for more collection settings when creating a new
WeaviateDocumentStore.It also adds a
docker-compose.ymlto start a Weaviate instance for testing purposes.The
document_storefixture also is added but not used as of now.