CI: sync API docs with readme.com #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
force-pushed
the
massi/readme-sync
branch
3 times, most recently
from
f4276e9 to
00cee9a
Compare
masci
force-pushed
the
massi/readme-sync
branch
from
aa15438 to
2d1b7c1
Compare
shadeMe
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
LGTM! The suggestion's optional. Feel free to merge (or not).
If we merge this workflow, it would fail for integration that don't support hatch run docs yet. Not sure if we should wait, let it fail, or add safeguards to skip the job when hatch run docs is not available
Just a thought: A probable outcome of skipping the job will be our procrastinating adding support for hatch in those integrations 😄 If it's not a lot of work, we might want to prioritize it.
|
Do not merge until #274 is complete |
github-actions
bot
added
integration:weaviate
integration:astra
integration:pgvector
labels
test commit, to be reverted Revert "test commit, to be reverted" This reverts commit b9997f7.
fine tune action settings try try try try
Co-authored-by: Madeesh Kannan <[email protected]>
This reverts commit 3538b01.
masci
force-pushed
the
massi/readme-sync
branch
from
74eed06 to
a8d8964
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changes to
integrations/*are merged onmain:Note for the reviewer:
hatch run docsyet. Not sure if we should wait, let it fail, or add safeguards to skip the job whenhatch run docsis not available