Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to convert from Document to Weaviate data object and viceversa #269

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

silvanocerza
Copy link
Contributor

Weaviate object doesn't have the same identical structure as our Document dataclass.
The keys are a bit different, we need to convert blobs, store the embeddings vector in a different manner, and other stuff.

For this reason we need to have a further conversion step.

This methods are not used as of now, further PRs will implement write_documents and filter_documents that make use of them.

@silvanocerza silvanocerza self-assigned this Jan 25, 2024
@silvanocerza silvanocerza requested a review from a team as a code owner January 25, 2024 12:04
@silvanocerza silvanocerza requested review from ZanSara and removed request for a team January 25, 2024 12:04
@silvanocerza silvanocerza force-pushed the weaviate-document-conversion branch 3 times, most recently from a7cb39a to e0101e0 Compare January 25, 2024 12:07
@silvanocerza silvanocerza force-pushed the weaviate-document-conversion branch from e0101e0 to 413df6f Compare January 25, 2024 12:10
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@silvanocerza silvanocerza merged commit 8db28ee into main Jan 25, 2024
8 checks passed
@silvanocerza silvanocerza deleted the weaviate-document-conversion branch January 25, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants