fix: Cohere namespace reorg #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vblagoje
commented
Jan 25, 2024
vblagoje
commented
- Reorganize namespace for generators, put both generators under cohere
- fixes inconsistency in streaming model chunk attribute naming haystack#6824
- Fixes for pre-release checks
- make sure all examples streaming and non streaming, component alone and in pipeline work well (both generators)
|
@julian-risch this PR includes minor fixes I discovered during pre-release testing and doc sync. I also fixed deepset-ai/haystack#6824 @annthurium found yesterday. |
|
yay! Thanks for the fix 😸 |
|
do we need to give @dfokina a heads up to change the docs for the |
masci
previously requested changes
Jan 25, 2024
| @@ -1,6 +0,0 @@ | |||
| # SPDX-FileCopyrightText: 2023-present deepset GmbH <[email protected]> | |||
| # | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
silvanocerza
approved these changes
Jan 25, 2024
julian-risch
dismissed
masci’s stale review
Massi's change requests were addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.