feat: Sagemaker integration: SagemakerGenerator
#276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZanSara
changed the title
SagemakerGenerator
vblagoje
requested changes
Jan 29, 2024
...azon_sagemaker/src/haystack_integrations/components/generators/amazon_sagemaker/sagemaker.py
Show resolved
Hide resolved
...azon_sagemaker/src/haystack_integrations/components/generators/amazon_sagemaker/sagemaker.py
Show resolved
Hide resolved
...azon_sagemaker/src/haystack_integrations/components/generators/amazon_sagemaker/sagemaker.py
Show resolved
Hide resolved
vblagoje
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
SagemakerGenerator#275Proposed Changes:
SagemakerGeneratorwith a very basic set of features (no streaming, no chat, only text inference)How did you test it?
Local unit and integration tests, unit tests in CI.
NOTE: integration tests won't run in the CI for now - keeping up the endpoint for these tests is very expensive.
Notes for the reviewer
As keeping Sagemaker endpoints up for testing is very expensive, integration tests are not going to run in CI.