Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for streaming ollama generator #280

Merged
merged 12 commits into from
Feb 12, 2024
Merged

Support for streaming ollama generator #280

merged 12 commits into from
Feb 12, 2024

Conversation

sachinsachdeva
Copy link
Contributor

@sachinsachdeva sachinsachdeva commented Jan 27, 2024 •
edited
Loading

Implements #167

  • Support Streaming for ollama generator
  • Add/update tests
  • implement serializing/deserializing for OllamaGenerator

@sachinsachdeva sachinsachdeva mentioned this pull request Jan 27, 2024
Closed
@anakin87
Copy link
Member

anakin87 commented Feb 1, 2024

Hey, @sachinsachdeva!
Thanks for working on this...

When you want this PR to be reviewed, put it in "Ready for review" status.

In the meantime, I would say that now that the Generator also accepts a streaming callback, we should also take care of properly serializing/deserializing this component. You can refer to the methods to_dict/from_dict of the OpenAI Generator.

Let me know if you need any help or directions.

@sachinsachdeva sachinsachdeva marked this pull request as ready for review February 6, 2024 17:43
@sachinsachdeva sachinsachdeva requested a review from a team as a code owner February 6, 2024 17:43
@sachinsachdeva sachinsachdeva requested review from ZanSara and removed request for a team February 6, 2024 17:43
@sachinsachdeva
Copy link
Contributor Author

@anakin87 ready for review now

@github-actions github-actions bot added the type:documentation Improvements or additions to documentation label Feb 7, 2024
ZanSara
ZanSara reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sachinsachdeva, I'm going to test this PR locally soon. In the meantime I left two minor comments.

integrations/ollama/src/haystack_integrations/components/generators/ollama/generator.py Outdated Show resolved Hide resolved
integrations/ollama/tests/test_generator.py Outdated Show resolved Hide resolved
@ZanSara ZanSara self-assigned this Feb 8, 2024
ZanSara
ZanSara approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it works well. Thank you for your contribution! 🤗

@ZanSara ZanSara merged commit 09831a6 into deepset-ai:main Feb 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara approved these changes

Assignees

@ZanSara ZanSara

Labels
integration:ollama type:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sachinsachdeva @anakin87 @ZanSara