Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinecone - decrease concurrency in tests #323

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Pinecone - decrease concurrency in tests #323

merged 2 commits into from
Feb 1, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Feb 1, 2024 •
edited
Loading

Pinecone tests keep failing, despite my recent attempt to fix them in #288.

The error is "Too Many Requests".
So I am doing two things:

  • decrease the concurrency in tests (lowering the number of workers from 3 to 2)
  • decrease the sleep time a bit, since it does not seem to be responsible for this error

@anakin87 anakin87 marked this pull request as ready for review February 1, 2024 07:47
@anakin87 anakin87 requested a review from a team as a code owner February 1, 2024 07:47
@anakin87 anakin87 requested review from ZanSara and removed request for a team February 1, 2024 07:47
ZanSara
ZanSara approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let's hope this is enough to at least reduce the flakyness of the test.

@ZanSara ZanSara merged commit bdee933 into main Feb 1, 2024
5 checks passed
@ZanSara ZanSara deleted the pinecone-decrease-concurrency branch February 1, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara approved these changes

Assignees
No one assigned
Labels
integration:pinecone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anakin87 @ZanSara