Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amazon bedrock: generate api docs #326

Merged
merged 7 commits into from
Feb 8, 2024
Merged

amazon bedrock: generate api docs #326

merged 7 commits into from
Feb 8, 2024

Conversation

dfokina
Copy link
Contributor

@dfokina dfokina commented Feb 1, 2024

Fixes #302

@dfokina dfokina requested a review from a team as a code owner February 1, 2024 17:50
@dfokina dfokina requested review from ZanSara and removed request for a team February 1, 2024 17:50
ZanSara
ZanSara suggested changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some modules are missing from the config

integrations/amazon_bedrock/pydoc/config.yml Show resolved Hide resolved
@dfokina dfokina requested a review from ZanSara February 2, 2024 12:49
ZanSara
ZanSara approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZanSara ZanSara merged commit ee5f3c0 into main Feb 8, 2024
9 checks passed
@ZanSara ZanSara deleted the apidocs-bedrock branch February 8, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara approved these changes

Assignees
No one assigned
Labels
integration:amazon-bedrock topic:CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

amazon_bedrock: generate api docs
2 participants
@dfokina @ZanSara