[instructor] Fix osx install #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
requested review from
julian-risch and
anakin87
and removed request for
a team
anakin87
reviewed
Oct 10, 2023
There was a problem hiding this comment.
It's a strange pin, copied from the original Instructor requirements...
After a check, I'm quite sure this dependency is not needed.
In fact, datasets already installs it:
https://github.com/huggingface/datasets/blob/7d357eb4b499cd530c3f4e626f2825a50ee6c8aa/setup.py#L114
(and pyarrow is never used directly in the InstructorEmbedding package)
I would remove/comment the dependency.
ElenaKusevska
added a commit
to Anant/haystack-core-integrations
that referenced
this pull request
Dec 22, 2023
use new Document dataclass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pinned version of
pyarrowcan't install on OSX. Removing the pin still works, not sure if we want to test the package in other environments to confirm.Also exported the embedders in the root package for convenience.