Add the Cohere client name to cohere requests #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shadeMe
approved these changes
Feb 8, 2024
|
Thanks for signing the CLA! I'll get it merged once the test are fixed. |
For the tests what is the expectation for the API keys, do you have a test API key? |
I think the failures are due to the lints? We run a nightly test with our CI API key, so this PR will be fine to merge as long as the changes were tested locally (with a valid API). EDIT: I see that some of the unit tests don't mock the API key correctly. I'm merging the main branch; should hopefully fix those errors. |
github-actions
bot
added
the
type:documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the client name to Cohere to support debugging and tracing of requests