Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinecone: rename retriever #396

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Pinecone: rename retriever #396

merged 3 commits into from
Feb 12, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Feb 12, 2024

part of #395

for consistency, PineconeDenseRetriever -> PineconeEmbeddingRetriever

I also took the opportunity to convert the example notebook to an example script, which is more consistent with the other integrations.

@github-actions github-actions bot added integration:pinecone type:documentation Improvements or additions to documentation labels Feb 12, 2024
@anakin87 anakin87 marked this pull request as ready for review February 12, 2024 16:07
@anakin87 anakin87 requested a review from a team as a code owner February 12, 2024 16:07
@anakin87 anakin87 requested review from shadeMe and removed request for a team February 12, 2024 16:07
@anakin87 anakin87 merged commit 1167b8f into main Feb 12, 2024
6 checks passed
@anakin87 anakin87 deleted the pinecone-rename-retriever branch February 12, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:pinecone type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants