Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astra: rename retriever #399

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Astra: rename retriever #399

merged 1 commit into from
Feb 13, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Feb 12, 2024

part of #394

for consistency, AstraRetriever -> AstraEmbeddingRetriever

@github-actions github-actions bot added integration:astra type:documentation Improvements or additions to documentation labels Feb 12, 2024
@anakin87 anakin87 marked this pull request as ready for review February 12, 2024 17:35
@anakin87 anakin87 requested a review from a team as a code owner February 12, 2024 17:35
@anakin87 anakin87 requested review from davidsbatista and removed request for a team February 12, 2024 17:35
Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anakin87 anakin87 merged commit f85f838 into main Feb 13, 2024
10 checks passed
@anakin87 anakin87 deleted the astra-rename-retriever branch February 13, 2024 11:24
jmdevita pushed a commit to jmdevita/haystack-core-integrations that referenced this pull request Feb 14, 2024
vblagoje pushed a commit that referenced this pull request Feb 15, 2024
* Added ollama document embedder and tests

* Cleaning of non-used variables and batch restrictions

* Fixed issue with test_document_embedder.py import_text_in_embedder test, test was incorrect

* Fixed lint issues and tests

* chore: Exculde evaluator private classes in API docs (#392)

* rename astraretriever (#399)

* rename retriever (#407)

* test patch- documents embedding wasn't working as expected

---------

Co-authored-by: Madeesh Kannan <[email protected]>
Co-authored-by: Stefano Fiorucci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:astra type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants