-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt Secret
to pgvector
#402
Conversation
Hey! I'm not still an expert on the new Secret management. I think your implementation should follow in some way that of In the current PR, I see that the I don't know what the best way to approach this is, and I would leave it to you to experiment/decide. Let me know what you think and if you need help. |
thanks for your comments @anakin87 - I did some changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
I left a comment with a doubt. if it makes sense, please consider it.
PostgreSQL connection string, read from an environment variable with the
Secret
component:from_dict
method to the doc store classstaticmethod
, since the self was not being usedcoverage
config so that it actually shows the coverage over code and not test