Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding mistral generator and embedders #409

Merged
merged 18 commits into from
Feb 16, 2024
Merged

Adding mistral generator and embedders #409

merged 18 commits into from
Feb 16, 2024

Conversation

TuanaCelik
Copy link
Contributor

@TuanaCelik TuanaCelik commented Feb 13, 2024 •
edited
Loading

This PR adds the MistralChatGenerator, the MistralDocumentEmbedder and the MistralTextEmbedder.

There are still 2 thing I'd like to finish:

  • Add tests
  • Add examples

@TuanaCelik TuanaCelik requested a review from a team as a code owner February 13, 2024 21:56
@TuanaCelik TuanaCelik requested review from davidsbatista and removed request for a team February 13, 2024 21:56
@github-actions github-actions bot added topic:CI type:documentation Improvements or additions to documentation labels Feb 13, 2024
@TuanaCelik TuanaCelik mentioned this pull request Feb 13, 2024
Closed
@TuanaCelik
Copy link
Contributor Author

TuanaCelik commented Feb 15, 2024 •
edited
Loading

Notes:

  • I created the chat generator tests from the openai chat generator tests
  • let me know if this was not best practice as I re-made the mode chat chunks etc inside the test files here.
  • Additionally, I had fixed some linting issues locally but in particular fixinv the complaining on super() caused issues. My tests stopped working when changing from super(classname, self) to super().. What do?

@TuanaCelik
Copy link
Contributor Author

Additional note:

@TuanaCelik TuanaCelik requested a review from shadeMe February 15, 2024 16:52
shadeMe
shadeMe suggested changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small changes. Once those are added and the tests pass, this will look good to merge!

.github/workflows/mistral.yml Show resolved Hide resolved
integrations/mistral/pyproject.toml Outdated Show resolved Hide resolved
integrations/mistral/pyproject.toml Outdated Show resolved Hide resolved
...grations/mistral/src/haystack_integrations/components/embedders/mistral/document_embedder.py Outdated Show resolved Hide resolved
integrations/mistral/src/haystack_integrations/components/embedders/mistral/text_embedder.py Outdated Show resolved Hide resolved
integrations/mistral/src/haystack_integrations/components/embedders/mistral/text_embedder.py Outdated Show resolved Hide resolved
...tions/mistral/src/haystack_integrations/components/generators/mistral/chat/chat_generator.py Outdated Show resolved Hide resolved
@TuanaCelik TuanaCelik self-assigned this Feb 16, 2024
shadeMe
shadeMe suggested changes Feb 16, 2024
View reviewed changes
.github/workflows/mistral.yml Outdated Show resolved Hide resolved
@shadeMe shadeMe merged commit a19fc7b into main Feb 16, 2024
10 checks passed
@shadeMe shadeMe deleted the tuana/mistral branch February 16, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadeMe shadeMe shadeMe approved these changes

@davidsbatista davidsbatista Awaiting requested review from davidsbatista

Assignees

@TuanaCelik TuanaCelik

Labels
integration:mistral topic:CI type:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TuanaCelik @shadeMe @davidsbatista