-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: MongoDBAtlasEmbeddingRetriever
#427
Conversation
2d3a6f1
to
7c80cbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some comments. I'll also add @masci as a reviewer as I might not have enough context to review the MongoDB-specific code.
...b_atlas/src/haystack_integrations/components/retrievers/mongodb_atlas/embedding_retriever.py
Outdated
Show resolved
Hide resolved
...b_atlas/src/haystack_integrations/components/retrievers/mongodb_atlas/embedding_retriever.py
Outdated
Show resolved
Hide resolved
...b_atlas/src/haystack_integrations/components/retrievers/mongodb_atlas/embedding_retriever.py
Outdated
Show resolved
Hide resolved
...b_atlas/src/haystack_integrations/components/retrievers/mongodb_atlas/embedding_retriever.py
Show resolved
Hide resolved
...b_atlas/src/haystack_integrations/components/retrievers/mongodb_atlas/embedding_retriever.py
Show resolved
Hide resolved
...b_atlas/src/haystack_integrations/components/retrievers/mongodb_atlas/embedding_retriever.py
Show resolved
Hide resolved
...ions/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas/document_store.py
Outdated
Show resolved
Hide resolved
...ions/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas/document_store.py
Outdated
Show resolved
Hide resolved
...ions/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas/document_store.py
Outdated
Show resolved
Hide resolved
…s/retrievers/mongodb_atlas/embedding_retriever.py Co-authored-by: Madeesh Kannan <[email protected]>
…s/retrievers/mongodb_atlas/embedding_retriever.py
…s/retrievers/mongodb_atlas/embedding_retriever.py
…s/retrievers/mongodb_atlas/embedding_retriever.py
...b_atlas/src/haystack_integrations/components/retrievers/mongodb_atlas/embedding_retriever.py
Outdated
Show resolved
Hide resolved
…s/retrievers/mongodb_atlas/embedding_retriever.py
…stores/mongodb_atlas/document_store.py
…stores/mongodb_atlas/document_store.py Co-authored-by: Madeesh Kannan <[email protected]>
…stores/mongodb_atlas/document_store.py Co-authored-by: Madeesh Kannan <[email protected]>
...ions/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas/document_store.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; I'll let @masci have the last word on it.
...ions/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas/document_store.py
Show resolved
Hide resolved
...b_atlas/src/haystack_integrations/components/retrievers/mongodb_atlas/embedding_retriever.py
Outdated
Show resolved
Hide resolved
...ions/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas/document_store.py
Outdated
Show resolved
Hide resolved
…s/retrievers/mongodb_atlas/embedding_retriever.py Co-authored-by: Silvano Cerza <[email protected]>
...ions/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas/document_store.py
Outdated
Show resolved
Hide resolved
…ystack-core-integrations into mongodbatlas-emb-retriever
Part of #143
Note: recreate_collection was removed because it doesn't make too much sense with how MongoDB Atlas works. Collections need to be created manually from the web UI to work with an embedding retriever, and right now this document store has no other retrieval methods. When APIs are introduced to create these collections and indices from code, or when we introduce alternative retrieval methods, we can evaluate whether to add this feature back.