Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MongoDBAtlasEmbeddingRetriever #427

Merged
merged 34 commits into from
Feb 23, 2024
Merged

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Feb 15, 2024

Part of #143

Note: recreate_collection was removed because it doesn't make too much sense with how MongoDB Atlas works. Collections need to be created manually from the web UI to work with an embedding retriever, and right now this document store has no other retrieval methods. When APIs are introduced to create these collections and indices from code, or when we introduce alternative retrieval methods, we can evaluate whether to add this feature back.

@github-actions github-actions bot added integration:mongodb-atlas type:documentation Improvements or additions to documentation labels Feb 15, 2024
@ZanSara ZanSara force-pushed the mongodbatlas-emb-retriever branch from 2d3a6f1 to 7c80cbc Compare February 15, 2024 16:54
@ZanSara ZanSara mentioned this pull request Feb 15, 2024
12 tasks
@ZanSara ZanSara self-assigned this Feb 15, 2024
@ZanSara ZanSara marked this pull request as ready for review February 21, 2024 13:13
@ZanSara ZanSara requested a review from a team as a code owner February 21, 2024 13:13
@ZanSara ZanSara requested review from shadeMe and removed request for a team February 21, 2024 13:13
Copy link
Contributor

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comments. I'll also add @masci as a reviewer as I might not have enough context to review the MongoDB-specific code.

@shadeMe shadeMe requested a review from masci February 21, 2024 14:03
ZanSara and others added 4 commits February 21, 2024 17:34
…s/retrievers/mongodb_atlas/embedding_retriever.py

Co-authored-by: Madeesh Kannan <[email protected]>
…s/retrievers/mongodb_atlas/embedding_retriever.py
…s/retrievers/mongodb_atlas/embedding_retriever.py
…s/retrievers/mongodb_atlas/embedding_retriever.py
ZanSara and others added 4 commits February 21, 2024 17:42
…s/retrievers/mongodb_atlas/embedding_retriever.py
…stores/mongodb_atlas/document_store.py

Co-authored-by: Madeesh Kannan <[email protected]>
…stores/mongodb_atlas/document_store.py

Co-authored-by: Madeesh Kannan <[email protected]>
@ZanSara ZanSara requested a review from shadeMe February 21, 2024 16:59
Copy link
Contributor

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I'll let @masci have the last word on it.

…s/retrievers/mongodb_atlas/embedding_retriever.py

Co-authored-by: Silvano Cerza <[email protected]>
@ZanSara ZanSara merged commit 8f73a8b into main Feb 23, 2024
16 checks passed
@ZanSara ZanSara deleted the mongodbatlas-emb-retriever branch February 23, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants