Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contribution guidelines #437

Merged
merged 7 commits into from
Feb 20, 2024
Merged

Add contribution guidelines #437

merged 7 commits into from
Feb 20, 2024

Conversation

masci
Copy link
Contributor

@masci masci commented Feb 18, 2024 •
edited
Loading

@masci masci requested a review from a team as a code owner February 18, 2024 10:12
@masci masci requested review from silvanocerza and removed request for a team February 18, 2024 10:12
@masci masci requested review from a team and dfokina February 18, 2024 10:13
masci
masci commented Feb 18, 2024
View reviewed changes
CONTRIBUTING.md Show resolved Hide resolved
dfokina
dfokina reviewed Feb 19, 2024
View reviewed changes
Copy link
Contributor

@dfokina dfokina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including the docs, Massi! I left some language suggestions to make it clearer, but also wondering if we want to explain working with the pydoc config files?

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
silvanocerza
silvanocerza reviewed Feb 20, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
silvanocerza
silvanocerza reviewed Feb 20, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
silvanocerza
silvanocerza approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some links to fix but apart from that it's fine. Feel free to merge after the links are good. 👍

@masci masci merged commit 94cd08d into main Feb 20, 2024
3 checks passed
@masci masci deleted the massi/contrib branch February 20, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfokina dfokina dfokina left review comments

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
topic:DX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masci @silvanocerza @dfokina