Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastembed integration new parameters #446

Merged
merged 7 commits into from
Feb 20, 2024
Merged

fastembed integration new parameters #446

merged 7 commits into from
Feb 20, 2024

Conversation

nickprock
Copy link
Contributor

@nickprock nickprock commented Feb 20, 2024 •
edited
Loading

I added new parameters:

  • cache_dir
  • threads

related issue #358

@nickprock nickprock requested a review from a team as a code owner February 20, 2024 10:05
@nickprock nickprock requested review from ZanSara and removed request for a team February 20, 2024 10:05
@github-actions github-actions bot added integration:fastembed type:documentation Improvements or additions to documentation labels Feb 20, 2024
@anakin87 anakin87 requested review from anakin87 and removed request for ZanSara February 20, 2024 10:17
anakin87
anakin87 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good...
thanks!

@anakin87 anakin87 merged commit f3ea6be into deepset-ai:main Feb 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

Assignees
No one assigned
Labels
integration:fastembed type:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickprock @anakin87