Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Astra tests #448

Closed
wants to merge 2 commits into from
Closed

fix Astra tests #448

wants to merge 2 commits into from

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Feb 20, 2024 •
edited
Loading

the embedding_dim was renamed to embedding_dimension in #428,
but the document store fixture was not changed accordingly.

trying to fix...

UPDATE: it seems more difficult than I thought it would be.

@anakin87 anakin87 requested a review from a team as a code owner February 20, 2024 12:03
@anakin87 anakin87 requested review from davidsbatista and removed request for a team February 20, 2024 12:03
@anakin87 anakin87 marked this pull request as draft February 20, 2024 12:15
@anakin87
Copy link
Member Author

Closing, since Massi is working on a better solution

@anakin87 anakin87 closed this Feb 20, 2024
@masci masci deleted the fix-astra-tests branch April 4, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbatista davidsbatista Awaiting requested review from davidsbatista davidsbatista is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
integration:astra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anakin87