chore: Use serialize_callable instead of serialize_callback_handler in Cohere
#460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure if I'm seeing the whole thing here, but, instead of a new beta release, wouldn't the tests pass with this issue fixed, i.e: test |
|
@davidsbatista that would be a nightly workflow that prevents the opposite scenario: a Haystack release that breaks existing integrations. I agree that the whole workflow needs work, it would make sense that the main of integrations work on the main of Haystack, but for now it's safer to test everything primarily against the released Haystack. |
davidsbatista
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #415
NOTE: requires a new beta release for the tests to pass. Don't merge!