Unstructured: review docstrings #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:unstructured-fileconverter
type:documentation
anakin87
commented
Mar 4, 2024
...tions/unstructured/src/haystack_integrations/components/converters/unstructured/converter.py
Show resolved
Hide resolved
anakin87
commented
Mar 4, 2024
Comment on lines
+64
to
+67
| `"one-doc-per-file"`: One Haystack Document per file. All elements are concatenated into one text field. | ||
| `"one-doc-per-page"`: One Haystack Document per page. | ||
| All elements on a page are concatenated into one text field. | ||
| `"one-doc-per-element"`: One Haystack Document per element. Each element is converted to a Haystack Document. |
There was a problem hiding this comment.
Bulleted lists inside a specific parameter do not play well with pydoc-markdown
There was a problem hiding this comment.
Hmm, this should've been an enum instead of a string literal. We should open an issue to convert this (later).
shadeMe
approved these changes
Mar 4, 2024
Comment on lines
+64
to
+67
| `"one-doc-per-file"`: One Haystack Document per file. All elements are concatenated into one text field. | ||
| `"one-doc-per-page"`: One Haystack Document per page. | ||
| All elements on a page are concatenated into one text field. | ||
| `"one-doc-per-element"`: One Haystack Document per element. Each element is converted to a Haystack Document. |
There was a problem hiding this comment.
Hmm, this should've been an enum instead of a string literal. We should open an issue to convert this (later).
...tions/unstructured/src/haystack_integrations/components/converters/unstructured/converter.py
Outdated
Show resolved
Hide resolved
…/converters/unstructured/converter.py Co-authored-by: Madeesh Kannan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes deepset-ai/haystack#7150