Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add NvidiaTextEmbedder, NvidiaDocumentEmbedder and co. #537

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

shadeMe
Copy link
Contributor

@shadeMe shadeMe commented Mar 5, 2024

@github-actions github-actions bot added integration:nvidia type:documentation Improvements or additions to documentation labels Mar 5, 2024
@shadeMe shadeMe marked this pull request as ready for review March 5, 2024 16:52
@shadeMe shadeMe requested a review from a team as a code owner March 5, 2024 16:52
@shadeMe shadeMe requested review from davidsbatista and silvanocerza and removed request for a team and davidsbatista March 5, 2024 16:52
@silvanocerza silvanocerza merged commit d4a2ed5 into main Mar 6, 2024
10 checks passed
@silvanocerza silvanocerza deleted the feat/nvidia-embedder branch March 6, 2024 09:15
@davidsbatista
Copy link
Contributor

I was doing a review, do you still want my comments?

@davidsbatista
Copy link
Contributor

Overall seems to me a very good job, and kudos for already implementing the batch processing!

My only comment is regarding the assert in the code. I think assertions are better suited for tests or debugging proposes.

  • If they are needed due to the type checker limitations, I would suggest a # type: ignore
  • Otherwise, why not test the condition and raise an Exception?
  • Also, asserts can be ignored by passing the -O flag to the interpreter

NOTE: this is not a blocker for me, I am just curious why you use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:nvidia type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants