-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add JinaRanker component #539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, it looks good.
I left some minor comments.
integrations/jina/src/haystack_integrations/components/rankers/jina/ranker.py
Outdated
Show resolved
Hide resolved
integrations/jina/src/haystack_integrations/components/rankers/jina/ranker.py
Outdated
Show resolved
Hide resolved
Done @anakin87, I hope is fine now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I also tried it locally and works well.
Released a new version of the package, which includes support for the Ranker: https://pypi.org/project/jina-haystack/0.3.0/ |
add JinaRanker module to the jina integrations