Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add JinaRanker component #539

Merged
merged 8 commits into from
Mar 19, 2024
Merged

Conversation

JoanFM
Copy link
Contributor

@JoanFM JoanFM commented Mar 6, 2024

add JinaRanker module to the jina integrations

@github-actions github-actions bot added integration:jina type:documentation Improvements or additions to documentation labels Mar 6, 2024
@JoanFM JoanFM force-pushed the add-jina-ranker branch from d6a302f to deb3dfa Compare March 6, 2024 14:16
@JoanFM JoanFM marked this pull request as ready for review March 6, 2024 14:16
@JoanFM JoanFM requested a review from a team as a code owner March 6, 2024 14:17
@JoanFM JoanFM requested review from shadeMe and removed request for a team March 6, 2024 14:17
@JoanFM JoanFM force-pushed the add-jina-ranker branch from 9b4498c to dad252f Compare March 6, 2024 14:37
@TuanaCelik TuanaCelik requested review from anakin87 and removed request for shadeMe March 18, 2024 10:09
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it looks good.

I left some minor comments.

@JoanFM
Copy link
Contributor Author

JoanFM commented Mar 19, 2024

In general, it looks good.

I left some minor comments.

Done @anakin87, I hope is fine now

@JoanFM JoanFM requested a review from anakin87 March 19, 2024 09:39
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I also tried it locally and works well.

@anakin87 anakin87 merged commit 893b2cb into deepset-ai:main Mar 19, 2024
10 checks passed
@anakin87
Copy link
Member

Released a new version of the package, which includes support for the Ranker: https://pypi.org/project/jina-haystack/0.3.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:jina type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants