docs: review integrations sagemaker #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:amazon-sagemaker
type:documentation
wochinge
commented
Mar 6, 2024
| @@ -1,46 +1,16 @@ | |||
| from typing import Optional | |||
There was a problem hiding this comment.
that was all unnecessary reimplementation
wochinge
commented
Mar 6, 2024
| @@ -249,5 +249,5 @@ def run(self, prompt: str, generation_kwargs: Optional[Dict[str, Any]] = None): | |||
| msg = f"Sagemaker model not ready: {res.text}" | |||
| raise SagemakerNotReadyError(msg) from err | |||
|
|
|||
| msg = f"SageMaker Inference returned an error. Status code: {res.status_code} Response body: {res.text}" | |||
| raise SagemakerInferenceError(msg, status_code=res.status_code) from err | |||
There was a problem hiding this comment.
this exception doesn't take a param status_code
wochinge
changed the title
wochinge
requested review from
vblagoje and
silvanocerza
and removed request for
a team
vblagoje
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
integrations.amazon_sagemakerhaystack#7181