-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Qdrant): allow payload indexing + on disk vectors #553
feat(Qdrant): allow payload indexing + on disk vectors #553
Conversation
I guess the PR is ready. Should we ping Qdrant people ? Because I read somewhere that they are the one maintaining this ? https://qdrant.tech/documentation/frameworks/haystack/ |
It was someone from Qdrant who originally wrote the code, so let's ask them to review it. |
@Anush008 could you review this PR? |
integrations/qdrant/src/haystack_integrations/document_stores/qdrant/document_store.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you🙏
This is still a draft:
Related doc:
This MR aims to allow Qdrant user to create index on payload (metadata in Haystack naming) field.
This allow to filter way more efficiently vectors when searching.
And also it allows to restricti users to their own vectors only.
I'm open to comments, I'm not sure running it at each start-up of the collection is a good way to do it.
But From Qdrant discord:
https://discord.com/channels/907569970500743200/1214958671742902272/1214958671742902272 (if you are on their discord)
Adtionnally this add also the parameter
on_disk
that was not included in the integration, to store vectors on disk. See https://qdrant.tech/documentation/concepts/storage/#configuring-memmap-storage