feat: Add AnthropicGenerator and AnthropicChatGenerator #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type:documentation
vblagoje
force-pushed
the
anthropic_integration
branch
from
9b79e07 to
122f56f
Compare
|
@julian-risch not ready yet, just trying to run some CI, please don't review yet |
vblagoje
changed the title
|
We shouldn't use |
julian-risch
requested changes
Mar 14, 2024
| markers = [ | ||
| "unit: unit tests", | ||
| "integration: integration tests", | ||
| "generators: generators tests", |
There was a problem hiding this comment.
Let's add a marker for chat generators
"chat_generators: chat generator tests",
There was a problem hiding this comment.
And lets use the markers in the tests. Alternative would be to remove the "generators: generators tests", line here.
There was a problem hiding this comment.
I'll remove them, I don't see the point of using them :-)
...s/anthropic/src/haystack_integrations/components/generators/anthropic/chat/chat_generator.py
Outdated
Show resolved
Hide resolved
...s/anthropic/src/haystack_integrations/components/generators/anthropic/chat/chat_generator.py
Show resolved
Hide resolved
integrations/anthropic/src/haystack_integrations/components/generators/anthropic/generator.py
Show resolved
Hide resolved
| "system", | ||
| "max_tokens", | ||
| "metadata", | ||
| # "stream", explicitly passed to the interface |
There was a problem hiding this comment.
Let's just remove the line and if important mention it in docstrings.
...s/anthropic/src/haystack_integrations/components/generators/anthropic/chat/chat_generator.py
Outdated
Show resolved
Hide resolved
integrations/anthropic/example/documentation_rag_with_claude.py
Outdated
Show resolved
Hide resolved
julian-risch
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
This Pull Request introduces a new integration for the Haystack framework, enabling the use of Anthropic's Claude family of language models. Anthropic's API provides advanced features such as streaming responses and customizability, making it an excellent addition to Haystack's list of supported integrations.
What:
The PR adds:
integrations/anthropicincluding:srcdirectory containing the integration implementationtestsdirectory with test filespyproject.tomldefining build and packaging informationpydocdirectory with configuration and markdown file for automatically generated documentationLICENSE.txtfor the Apache License 2.0.github/workflows/anthropic.ymlfile to add CI workflows for testing and packagingAnthropicChatGeneratorandAnthropicGeneratorfor integrating with Anthropic's APIdocsdirectorytestsdirectoryHow can it be used:
AnthropicChatGeneratorandAnthropicGeneratorcomponents in your pipelines to generate responses and text using Anthropic's Claude family of modelsHow did you test it:
pytestto validate the components' functionalities, such as their interaction with the Anthropic API, input and output handling, and the serialization and deserialization processesNotes for the reviewer:
ANTHROPIC_API_KEYis setALLOWED_PARAMSvariable in both generator classes to confirm that the allowed parameters for Anthropic's API are up-to-date