Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinecone: temporarily skip failing tests #593

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Pinecone: temporarily skip failing tests #593

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90098f5
skip failing tests
anakin87 Mar 18, 2024
8749e73
lint
anakin87 Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions integrations/pinecone/tests/test_filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,3 +69,13 @@ def test_comparison_less_than_equal_with_none(self, document_store, filterable_d

@pytest.mark.skip(reason="Pinecone does not support the 'not' operator")
def test_not_operator(self, document_store, filterable_docs): ...

# the following skipped tests should be reworked when Pinecone introduces a better handling of null values
# see https://github.com/deepset-ai/haystack-core-integrations/issues/590
@pytest.mark.skip(reason="Pinecone does not include null values in the result of the $ne operator")
def test_comparison_not_equal(self, document_store, filterable_docs): ...

@pytest.mark.skip(
reason="Pinecone has inconsistent behavior with respect to other Document Stores with the $or operator"
)
def test_or_operator(self, document_store, filterable_docs): ...