Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NIM backend support #597

Merged
merged 20 commits into from
Mar 18, 2024
Merged

Add NIM backend support #597

merged 20 commits into from
Mar 18, 2024

Conversation

silvanocerza
Copy link
Contributor

No description provided.

@silvanocerza silvanocerza self-assigned this Mar 18, 2024
@silvanocerza silvanocerza requested a review from a team as a code owner March 18, 2024 16:23
@silvanocerza silvanocerza requested review from anakin87 and shadeMe and removed request for a team and anakin87 March 18, 2024 16:23
@github-actions github-actions bot added integration:nvidia type:documentation Improvements or additions to documentation labels Mar 18, 2024

from .backend import GeneratorBackend

MAX_INPUT_STRING_LENGTH = 2048
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use these to perform any checks. We should do that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required for generators, apparently.

Copy link
Contributor

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it far!

@silvanocerza silvanocerza merged commit 5a8796b into main Mar 18, 2024
10 checks passed
@silvanocerza silvanocerza deleted the feat/nvidia-nim-support branch March 18, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:nvidia type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants