Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for document_store.py #618

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Bug fix for document_store.py #618

merged 4 commits into from
Apr 24, 2024

Conversation

crtr0
Copy link
Contributor

@crtr0 crtr0 commented Mar 23, 2024

Fixed a bug where we ensure that a doc isn't already in our new_documents array before we consider adding it.

Fixed a bug where we ensure that a doc isn't already in our new_documents array before we consider adding it.
@crtr0 crtr0 requested a review from a team as a code owner March 23, 2024 23:15
@crtr0 crtr0 requested review from masci and removed request for a team March 23, 2024 23:15
@CLAassistant
Copy link

CLAassistant commented Mar 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Any chance you can add a unit test to cover this piece of logic?

@github-actions github-actions bot added the type:documentation Improvements or additions to documentation label Apr 24, 2024
@masci masci merged commit 1adbc2c into deepset-ai:main Apr 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:astra type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants