Pinecone - Skip test_comparison_not_equal_with_dataframe
#647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
approved these changes
Apr 8, 2024
anakin87
deleted the
pinecone-skip-test_comparison_not_equal_with_dataframe
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently started to see failures like this: https://github.com/deepset-ai/haystack-core-integrations/actions/runs/8592581603/job/23542797620
document_store.filter_documents(filters={"field": "dataframe", "operator": "!=", "value": pd.DataFrame([1])}returns only the Documents with a
dataframefield with a different value, not Documents wheredataframeis null.This happens because of Pinecone's new handling of null values (explained in #590).
Metadata filtering in Pinecone seems to be a work in progress, so I would propose to skip this failing test for the time being and rework the filters when the mechanism is more stable on their end.