Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename QdrantSparseRetriever to QdrantSparseEmbeddingRetriever #681

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

anakin87
Copy link
Member

I realized that QdrantSparseRetriever should be QdrantSparseEmbeddingRetriever,
according to our naming convention for Retrievers.

Luckily, this feature has not yet been documented or promoted.

I'm renaming the retriever.

@github-actions github-actions bot added integration:qdrant type:documentation Improvements or additions to documentation labels Apr 23, 2024
@anakin87 anakin87 marked this pull request as ready for review April 23, 2024 14:30
@anakin87 anakin87 requested a review from a team as a code owner April 23, 2024 14:30
@anakin87 anakin87 requested review from vblagoje and davidsbatista and removed request for a team April 23, 2024 14:30
@anakin87 anakin87 merged commit ffe0b74 into main Apr 23, 2024
10 checks passed
@anakin87 anakin87 deleted the qdrant-rename-sparse branch April 23, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:qdrant type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants