Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass namespace in the docstore init #683

Merged
merged 2 commits into from
Apr 24, 2024
Merged

fix: pass namespace in the docstore init #683

merged 2 commits into from
Apr 24, 2024

Conversation

masci
Copy link
Contributor

@masci masci commented Apr 24, 2024

Fixes #682

It's now possible to pass the namespace to the document store constructor.

@masci masci requested a review from a team as a code owner April 24, 2024 09:46
@masci masci requested review from julian-risch and removed request for a team April 24, 2024 09:46
@julian-risch julian-risch removed their request for review April 24, 2024 10:01
@anakin87 anakin87 self-requested a review April 24, 2024 10:10
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Feel free to merge if the tests pass

@masci masci merged commit 547c375 into main Apr 24, 2024
10 checks passed
@masci masci deleted the massi/682 branch April 24, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add namespace parameter to AstraDB integration
2 participants