Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test/WIP] feat: check compatibility #930

Closed
wants to merge 9 commits into from

Conversation

ArzelaAscoIi
Copy link
Member

Related Issues

  • fixes #issue-number

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@ArzelaAscoIi ArzelaAscoIi requested a review from a team as a code owner July 30, 2024 13:01
@ArzelaAscoIi ArzelaAscoIi requested review from anakin87 and removed request for a team July 30, 2024 13:01
@ArzelaAscoIi ArzelaAscoIi marked this pull request as draft July 30, 2024 13:04
@ArzelaAscoIi ArzelaAscoIi changed the title feat: check compatibility [Test/WIP] feat: check compatibility Jul 30, 2024
@silvanocerza
Copy link
Contributor

We shouldn't do this.

It's a mess that we decided we wanted to avoid completely with Haystack 2 and that's why we have the integrations completely separate.

This is a huge amount of work and creates a huge amount of conflicts and problems that we can't tackle in any way.

@wochinge
Copy link
Contributor

It's a mess that we decided we wanted to avoid completely with Haystack 2 and that's why we have the integrations completely separate.

Fair point. However, when we talked to @shadeMe suggested otherwise. The test seems like a pretty simple way to at least be aware of conflicts.

@wochinge
Copy link
Contributor

wochinge commented Aug 1, 2024

@ArzelaAscoIi Talked to Madeesh about this. Let's try it out in our pipeline-images repo. Depending on whether there is any problem in the first place, we can reevaluate what the best way forward is (e.g. if there is a simple maintainable fix or if we need to change our approach for building the images).

Based on the experience in our repository we can then probably also give better input on how much maintenance effort a similar check in this repository would be.

@ArzelaAscoIi
Copy link
Member Author

Sure! Sounds good

@silvanocerza silvanocerza deleted the feat/checkCompatibility branch August 12, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants