-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test/WIP] feat: check compatibility #930
Conversation
We shouldn't do this. It's a mess that we decided we wanted to avoid completely with Haystack 2 and that's why we have the integrations completely separate. This is a huge amount of work and creates a huge amount of conflicts and problems that we can't tackle in any way. |
Fair point. However, when we talked to @shadeMe suggested otherwise. The test seems like a pretty simple way to at least be aware of conflicts. |
@ArzelaAscoIi Talked to Madeesh about this. Let's try it out in our pipeline-images repo. Depending on whether there is any problem in the first place, we can reevaluate what the best way forward is (e.g. if there is a simple maintainable fix or if we need to change our approach for building the images). Based on the experience in our repository we can then probably also give better input on how much maintenance effort a similar check in this repository would be. |
Sure! Sounds good |
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.