Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update Anthropic example, use ChatPromptBuilder properly #978

Merged
merged 1 commit into from
Aug 14, 2024
Merged

chore: Update Anthropic example, use ChatPromptBuilder properly #978

merged 1 commit into from
Aug 14, 2024

Conversation

vblagoje
Copy link
Member

  • Properly use ChatPromptBuilder init with documents variable
  • Inject document content into prompt not just str of the document
  • Verify component connections
  • Verify output is based on fetched document

@vblagoje vblagoje requested a review from a team as a code owner August 14, 2024 08:39
@vblagoje vblagoje requested review from Amnah199 and davidsbatista and removed request for a team August 14, 2024 08:39
@github-actions github-actions bot added the type:documentation Improvements or additions to documentation label Aug 14, 2024
@vblagoje
Copy link
Member Author

@Amnah199 David and I talked about this example yesterday and how it needs an update. This is that update 😄

davidsbatista
davidsbatista approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now, ChatPrompBuilder changed

@davidsbatista
Copy link
Contributor

@vblagoje the docs also need to be updated: https://haystack.deepset.ai/integrations/anthropic#haystack-20

@vblagoje
Copy link
Member Author

Thank you for this @davidsbatista deepset-ai/haystack-integrations#254
All other docs are ok, merging this one

@vblagoje vblagoje merged commit 1caa410 into main Aug 14, 2024
10 checks passed
@vblagoje vblagoje deleted the fix_anthropic_example branch August 14, 2024 09:09
Amnah199 pushed a commit that referenced this pull request Oct 2, 2024
@vblagoje @Amnah199
Update Anthropic example, use ChatPromptBuilder properly (#978)
a9e9c9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbatista davidsbatista davidsbatista approved these changes

@Amnah199 Amnah199 Awaiting requested review from Amnah199 Amnah199 is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
type:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vblagoje @davidsbatista