Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Qdrant haystack #98

Merged
merged 9 commits into from
Dec 15, 2023
Merged

Conversation

Anush008
Copy link
Contributor

This PR intends to add Qdrant as a supported document store in Haystack 2.0.

@Anush008 Anush008 requested a review from a team as a code owner December 13, 2023 01:58
@Anush008 Anush008 requested review from julian-risch and removed request for a team December 13, 2023 01:58
@CLAassistant
Copy link

CLAassistant commented Dec 13, 2023

CLA assistant check
All committers have signed the CLA.

* chore: pin pyproject.toml version

* Update pyproject.toml

* Update pyproject.toml
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anush008 Looks very good to me! Just two small things before we can merge this PR. The utils.py seems to be empty so we should remove it. And the CLA Contributor License Agreement wasn't signed yet. Could you please sign it so that we can merge your PR? Thank you!

@Anush008
Copy link
Contributor Author

Hi @julian-risch. The requested changes should be resolved now.

Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 We can add a note to the integrations page about the 2.0 support next to sho up here https://haystack.deepset.ai/integrations/qdrant-document-store
That requires a change of this page: https://github.com/deepset-ai/haystack-integrations/blob/main/integrations/qdrant-document-store.md feel free to open a PR. You can find an example of how we structured such a page to list 1.x and 2.x support here: https://github.com/deepset-ai/haystack-integrations/blob/main/integrations/opensearch-document-store.md#table-of-contents

@julian-risch julian-risch merged commit 71e20eb into deepset-ai:main Dec 15, 2023
7 checks passed
@Anush008 Anush008 deleted the qdrant-haystack branch December 20, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants