-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Qdrant haystack #98
Conversation
* docs: Update README.md * chore: mypy overrides
* chore: pin pyproject.toml version * Update pyproject.toml * Update pyproject.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Anush008 Looks very good to me! Just two small things before we can merge this PR. The utils.py seems to be empty so we should remove it. And the CLA Contributor License Agreement wasn't signed yet. Could you please sign it so that we can merge your PR? Thank you!
Hi @julian-risch. The requested changes should be resolved now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍 We can add a note to the integrations page about the 2.0 support next to sho up here https://haystack.deepset.ai/integrations/qdrant-document-store
That requires a change of this page: https://github.com/deepset-ai/haystack-integrations/blob/main/integrations/qdrant-document-store.md feel free to open a PR. You can find an example of how we structured such a page to list 1.x and 2.x support here: https://github.com/deepset-ai/haystack-integrations/blob/main/integrations/opensearch-document-store.md#table-of-contents
This PR intends to add Qdrant as a supported document store in Haystack 2.0.