Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add link to langfuse in LangfuseConnector #981

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

marcklingen
Copy link
Contributor

Related Issues

None

Proposed Changes:

I propose to add a link to Langfuse to help people figure out what Langfuse actually is when browsing the api reference.

How did you test it?

I did not test it

Notes for the reviewer

None

Checklist

@marcklingen marcklingen requested a review from a team as a code owner August 15, 2024 16:33
@marcklingen marcklingen requested review from shadeMe and removed request for a team August 15, 2024 16:33
@CLAassistant
Copy link

CLAassistant commented Aug 15, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added integration:langfuse type:documentation Improvements or additions to documentation labels Aug 15, 2024
@marcklingen
Copy link
Contributor Author

@vblagoje What do you think? I saw a link when checking out the chroma integration api reference and thought it would be useful on the langfuse page as well.

@vblagoje
Copy link
Member

Sounds good @marcklingen ! A small ask from our side is to add "Usage Notice" from https://docs.haystack.deepset.ai/docs/langfuseconnector somewhere in your https://langfuse.com/docs/integrations/haystack/get-started page as well. We had some users accidentally import one of the Haystack components before setting tracing enabled, leading to improper initialization ultimately resulting in no logs showing up in Langfuse. It's a common mistake our users face, see:

@marcklingen
Copy link
Contributor Author

marcklingen commented Aug 16, 2024

Thank you!

Got this feedback as well and added a note here: https://langfuse.com/docs/integrations/haystack/get-started#set-environment-variables

@shadeMe shadeMe requested review from vblagoje and removed request for shadeMe August 16, 2024 09:11
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update @marcklingen

@vblagoje vblagoje merged commit b293b76 into deepset-ai:main Aug 16, 2024
10 checks passed
Amnah199 pushed a commit that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:langfuse type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants