Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adapt to Ollama client 0.4.0 #139

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix: adapt to Ollama client 0.4.0 #139

merged 1 commit into from
Nov 22, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

  • update our code to make it work with ollama>=0.4.0
  • depend on ollama-haystack>=2.0.0 (which pins ollama>=0.4.0 and works properly with this version)

How did you test it?

CI

Checklist

@anakin87 anakin87 marked this pull request as ready for review November 22, 2024 14:39
@anakin87 anakin87 requested a review from a team as a code owner November 22, 2024 14:39
@anakin87 anakin87 requested review from shadeMe and removed request for a team November 22, 2024 14:39
@coveralls
Copy link

coveralls commented Nov 22, 2024

Pull Request Test Coverage Report for Build 11974659270

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 81.912%

Files with Coverage Reduction New Missed Lines %
components/generators/ollama/chat/chat_generator.py 5 93.18%
Totals Coverage Status
Change from base Build 11963918591: 0.01%
Covered Lines: 2305
Relevant Lines: 2814

💛 - Coveralls

@anakin87
Copy link
Member Author

All failing tests are unrelated: Anthropic overloaded; usual OpenAPITool failures.
I'm going to merge this PR.

@anakin87 anakin87 merged commit 4c1dd83 into main Nov 22, 2024
9 of 15 checks passed
@anakin87 anakin87 deleted the ollama-pydantic-fix branch November 22, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants