Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore:Format change in Anthropic response #160

Merged
merged 1 commit into from
Dec 18, 2024
Merged

chore:Format change in Anthropic response #160

merged 1 commit into from
Dec 18, 2024

Conversation

vblagoje
Copy link
Member

Update to the latest Anthropic usage format i.e. more specifically MessageStartEvent changed a bit to include more usage token fields

@vblagoje vblagoje marked this pull request as ready for review December 18, 2024 13:27
@vblagoje vblagoje requested a review from a team as a code owner December 18, 2024 13:27
@vblagoje vblagoje requested review from anakin87 and removed request for a team December 18, 2024 13:27
@vblagoje
Copy link
Member Author

@anakin87 please have a look, seems like an update in Anthropic lib

@coveralls
Copy link

coveralls commented Dec 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12396183932

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.197%
Totals Coverage Status
Change from base Build 12363707981: 0.0%
Covered Lines: 2035
Relevant Lines: 2446
💛 - Coveralls

@anakin87
Copy link
Member

I tried to fix that in deepset-ai/haystack-core-integrations#1252

@vblagoje
Copy link
Member Author

Deal @anakin87 let's release new Anthropic, I'll close this one

@vblagoje vblagoje closed this Dec 18, 2024
@vblagoje vblagoje reopened this Dec 18, 2024
@vblagoje
Copy link
Member Author

@anakin87 this is still needed even with the new anthropic-haystack that you just released.

anakin87
anakin87 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vblagoje vblagoje merged commit 58d9b57 into main Dec 18, 2024
23 checks passed
@vblagoje vblagoje deleted the fix_anthropic_format branch December 18, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vblagoje @coveralls @anakin87