Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating LLMMetaDataExtractor example code + notebook #167

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Jan 17, 2025

Proposed Changes:

  • Adding an example notebook on how to use the LLMMetaDataExtractor
  • Unless the word json is specified in the prompt OpenAI complains about the output format being in JSON, even with the "response_format": {"type": "json_object"} set

How did you test it?

  • manual verification

Checklist

@davidsbatista davidsbatista requested a review from a team as a code owner January 17, 2025 14:57
@davidsbatista davidsbatista requested review from Amnah199 and julian-risch and removed request for a team January 17, 2025 14:57
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@davidsbatista davidsbatista changed the title updating LLMMetaDataExtractor example code fix: updating LLMMetaDataExtractor example code + notebook Jan 17, 2025
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidsbatista davidsbatista merged commit f5b0a2f into main Jan 20, 2025
5 checks passed
@davidsbatista davidsbatista deleted the update-llmmetadataextract-prompt branch January 20, 2025 10:58
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12866505599

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.679%

Totals Coverage Status
Change from base Build 12865814691: 0.0%
Covered Lines: 1358
Relevant Lines: 1726

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants