Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update INSTRUCTOR-Embedders examples with refactored Document class #63

Merged

Conversation

awinml
Copy link
Contributor

@awinml awinml commented Nov 7, 2023

Related PR:

The INSTRUCTOR-Embedders package has been updated in deepset-ai/haystack-core-integrations#44 to support the refactored Document class. It has also been bumped to the new version in deepset-ai/haystack-core-integrations#46.

Proposed Changes:

This PR updates the examples on the integration page to comply with the refactored Document class and the new INSTRUCTOR-Embedders release.

Requesting Review:

@TuanaCelik @masci

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton @awinml! Hopefully we'll be soon done with these breaking changes but in the meantime we rely on manual interventions like these, super helpful!

@masci masci merged commit aa8c9ab into deepset-ai:main Nov 8, 2023
@awinml awinml deleted the update_instructor_integration_examples branch November 29, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants