Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

283 - Add scroll anchors to h2 and h3 for mdx based pages #305

Closed
wants to merge 1 commit into from

Conversation

fstau
Copy link
Contributor

@fstau fstau commented May 6, 2022

No description provided.

@vercel
Copy link

vercel bot commented May 6, 2022

@fstau is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@fstau fstau marked this pull request as ready for review May 6, 2022 09:05
@brandenchan
Copy link
Contributor

brandenchan commented May 6, 2022

Checked locally and it looks good for Overview, Components, Pipeline Nodes and Guides. @fstau what would it take to extend this to Tutorials and API Reference?

@brandenchan
Copy link
Contributor

Fixes #283

@fstau
Copy link
Contributor Author

fstau commented May 6, 2022

Checked locally and it looks good for Overview, Components, Pipeline Nodes and Guides. @fstau what would it take to extend this to Tutorials and API Reference?

@brandenchan There is a separate issue that requires extensive changes to the GetStaticProps in those files. I think it would be good to do it in that context.

@brandenchan
Copy link
Contributor

Ok understood

@vercel
Copy link

vercel bot commented May 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
haystack-website ❌ Failed (Inspect) May 18, 2022 at 11:01AM (UTC)

@masci masci linked an issue May 18, 2022 that may be closed by this pull request
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing because we changed the logic. Can you rebase on top of source please?

@fstau fstau closed this May 30, 2022
@fstau fstau deleted the dev/283-scroll-anchors branch May 30, 2022 13:21
@fstau fstau removed a link to an issue Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants